Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: templates in release URLs #3365

Merged
merged 1 commit into from Sep 11, 2022
Merged

fix: templates in release URLs #3365

merged 1 commit into from Sep 11, 2022

Conversation

caarlos0
Copy link
Member

closes #3356

closes #3356

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Sep 11, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Sep 11, 2022
@caarlos0 caarlos0 marked this pull request as ready for review September 11, 2022 17:18
@vercel vercel bot temporarily deployed to Preview September 11, 2022 17:19 Inactive
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #3365 (aaf28fd) into main (5185b5b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3365      +/-   ##
==========================================
- Coverage   83.90%   83.90%   -0.01%     
==========================================
  Files         115      115              
  Lines        9215     9212       -3     
==========================================
- Hits         7732     7729       -3     
  Misses       1206     1206              
  Partials      277      277              
Impacted Files Coverage Δ
internal/pipe/release/scm.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 2244bba into main Sep 11, 2022
10 of 12 checks passed
@caarlos0 caarlos0 deleted the url branch September 11, 2022 17:28
@github-actions github-actions bot added this to the 1.11.0 milestone Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with the {{ .ReleaseURL }} templating field on Slack notification
1 participant