Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yaml-lang-server modelines in init config #3376

Merged
merged 2 commits into from Sep 15, 2022
Merged

fix: yaml-lang-server modelines in init config #3376

merged 2 commits into from Sep 15, 2022

Conversation

caarlos0
Copy link
Member

  • docs on how to specify the schema to the lang server
  • add it automatically along with vim modelines to the init config
  • added it to our config as well

this should prevent some "out of date" schema issues, as well as mixing tabs with spaces and whatnot when an editorconfig plugin is not installed.

@caarlos0 caarlos0 added the bug Something isn't working label Sep 15, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2022
@caarlos0 caarlos0 added the docs A problem or enhancement in documentation label Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #3376 (956b75b) into main (707747d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3376   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files         115      115           
  Lines        9212     9212           
=======================================
  Hits         7725     7725           
  Misses       1210     1210           
  Partials      277      277           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 6606eec into main Sep 15, 2022
13 of 14 checks passed
@caarlos0 caarlos0 deleted the modelines branch September 15, 2022 12:41
@github-actions github-actions bot added this to the 1.11.0 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs A problem or enhancement in documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant