Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build --single-target when using specific targets #3381

Merged
merged 1 commit into from Sep 16, 2022

Conversation

caarlos0
Copy link
Member

When using specific targets in the config, single target becomes ineffective. This should fix it. This also removes other build options like gomips, goarm, goamd64, etc, as go will infer them from the current OS. In theory we should one day support all the GO* flags go build supports.

When using specific targets in the config, single target becomes
ineffective. This should fix it.

This also removes other build options like gomips, goarm, goamd64, etc,
as go will infer them from the current OS.

In theory we should one day support all the GO* flags go build supports.
@caarlos0 caarlos0 self-assigned this Sep 15, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Sep 15, 2022
@caarlos0 caarlos0 marked this pull request as ready for review Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #3381 (150ced1) into main (826944d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3381   +/-   ##
=======================================
  Coverage   83.85%   83.86%           
=======================================
  Files         115      115           
  Lines        9212     9216    +4     
=======================================
+ Hits         7725     7729    +4     
  Misses       1210     1210           
  Partials      277      277           
Impacted Files Coverage Δ
cmd/build.go 91.24% <100.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 0ea3e0f into main Sep 16, 2022
13 of 14 checks passed
@caarlos0 caarlos0 deleted the fix-single-target branch Sep 16, 2022
@github-actions github-actions bot added this to the 1.11.0 milestone Sep 16, 2022
@agilgur5
Copy link

For reference (as a backlink, since GH doesn't generate those for discussions, and for any future readers like me), this bug was noted in #3371 (reply in thread)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants