Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: binary archive when multiple builds #3385

Merged
merged 2 commits into from Sep 17, 2022
Merged

fix: binary archive when multiple builds #3385

merged 2 commits into from Sep 17, 2022

Conversation

caarlos0
Copy link
Member

closes #3383

closes #3383

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Sep 17, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Sep 17, 2022
@caarlos0 caarlos0 marked this pull request as ready for review Sep 17, 2022
@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #3385 (ed2b8c9) into main (0ea3e0f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3385   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         115      115           
  Lines        9216     9216           
=======================================
  Hits         7729     7729           
  Misses       1210     1210           
  Partials      277      277           
Impacted Files Coverage Δ
internal/pipe/archive/archive.go 93.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 36a48ea into main Sep 17, 2022
12 of 15 checks passed
@caarlos0 caarlos0 deleted the fix-bin-archive branch Sep 17, 2022
@github-actions github-actions bot added this to the 1.11.0 milestone Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid archive error when using goreleaser-pro
1 participant