Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: handle mixing of job and normal tokens #3415

Merged
merged 5 commits into from Sep 29, 2022

Conversation

drewstinnett
Copy link
Contributor

@drewstinnett drewstinnett commented Sep 28, 2022

If applied, this commit will allow for new GitLab clients to use both ci job tokens and plain tokens (for things like brew publishing where the CI_JOB_TOKEN isn't applicable)

This provides a fix for #3399


closes #3399

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2022
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor style stuff, lgtm otherwise!

thanks

internal/client/gitlab_test.go Outdated Show resolved Hide resolved
internal/client/gitlab.go Outdated Show resolved Hide resolved
internal/client/gitlab.go Outdated Show resolved Hide resolved
@caarlos0 caarlos0 added the bug Something isn't working label Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #3415 (7947eff) into main (c5904a9) will increase coverage by 0.02%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main    #3415      +/-   ##
==========================================
+ Coverage   83.87%   83.89%   +0.02%     
==========================================
  Files         115      115              
  Lines        9219     9233      +14     
==========================================
+ Hits         7732     7746      +14     
  Misses       1210     1210              
  Partials      277      277              
Impacted Files Coverage Δ
internal/client/gitlab.go 77.83% <93.33%> (+0.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

drewstinnett and others added 4 commits Sep 28, 2022
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@drewstinnett
Copy link
Contributor Author

Ty for the suggestions, teaching me all sorts of new things, much appreciated!! New code is up now

@caarlos0
Copy link
Member

Ty for the suggestions, teaching me all sorts of new things, much appreciated!! New code is up now

thank you for the fix! 🙏

@caarlos0 caarlos0 merged commit 3cad812 into goreleaser:main Sep 29, 2022
11 of 13 checks passed
@github-actions github-actions bot added this to the v1.11.0 milestone Sep 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error updating brew formula file statusCode=403
2 participants