Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gomod.env not being used #3434

Merged
merged 1 commit into from Oct 4, 2022
Merged

fix: gomod.env not being used #3434

merged 1 commit into from Oct 4, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 4, 2022

Fixes #3426

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Oct 4, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Oct 4, 2022
@caarlos0 caarlos0 marked this pull request as ready for review Oct 4, 2022
Copy link

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit 4a51099 into main Oct 4, 2022
10 of 11 checks passed
@caarlos0 caarlos0 deleted the gomod-env branch Oct 4, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Oct 4, 2022
@caarlos0 caarlos0 modified the milestones: v1.11.0, v1.12.0 Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gomod pipe should include config env so it works with Go Workspaces and Go.mod replace directives
2 participants