Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nfpm for ios #3436

Merged
merged 3 commits into from Oct 13, 2022
Merged

feat: nfpm for ios #3436

merged 3 commits into from Oct 13, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 5, 2022

Jailbroken iOS can install deb packages, and it seems the only change needed is to set the OS to ios instead of linux.

Closes #3410

cc/ @blacktop

Jailbroken iOS can install deb packages, and it seems the only change
needed is to set the OS to `ios` instead of `linux`.

Closes #3410
@caarlos0 caarlos0 added the enhancement New feature or request label Oct 5, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #3436 (a0e45d4) into main (7cd7351) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3436      +/-   ##
==========================================
+ Coverage   84.12%   84.13%   +0.01%     
==========================================
  Files         114      114              
  Lines        9220     9226       +6     
==========================================
+ Hits         7756     7762       +6     
  Misses       1188     1188              
  Partials      276      276              
Impacted Files Coverage Δ
internal/pipe/nfpm/nfpm.go 94.08% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 mentioned this pull request Oct 6, 2022
2 tasks
@blacktop
Copy link

blacktop commented Oct 6, 2022

#3410 (comment)

@caarlos0 does this also need to be added to nFPM?

@caarlos0
Copy link
Member Author

caarlos0 commented Oct 6, 2022

Nope, it's already there

Unless there are other specific differences between a Linux and iOS dev file, that's it 🤔

@blacktop
Copy link

blacktop commented Oct 7, 2022

cc/ @CRKatri @Arsen6331 just double checking we good?

@Arsen6331
Copy link
Contributor

just double checking we good?

Looks good to me

@CRKatri
Copy link

CRKatri commented Oct 7, 2022

Sorry if I'm blind, but where is the Architecture field set? And is it customizable? Because for iOS we technically need both iphoneos-arm and iphoneos-arm64 but both as 64bit (for compatibility reasons).

@caarlos0
Copy link
Member Author

caarlos0 commented Oct 11, 2022

Sorry if I'm blind, but where is the Architecture field set? And is it customizable? Because for iOS we technically need both iphoneos-arm and iphoneos-arm64 but both as 64bit (for compatibility reasons).

its the platform field in nfpm.

can we support only the latest? adding support for both would a bit messier

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview October 11, 2022 15:41 Inactive
@blacktop
Copy link

LGTM 👍

@caarlos0
Copy link
Member Author

so, is the iphoneos-arm64 only enough?

@CRKatri
Copy link

CRKatri commented Oct 12, 2022

I suppose.

@caarlos0 caarlos0 merged commit 080ccff into main Oct 13, 2022
12 of 13 checks passed
@caarlos0 caarlos0 deleted the nfpm-ios branch October 13, 2022 00:24
@github-actions github-actions bot added this to the v1.12.0 milestone Oct 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add iOS builds to nFPM deb pkgs
4 participants