Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more templateable fields for blobs #3461

Merged
merged 2 commits into from Oct 14, 2022
Merged

feat: more templateable fields for blobs #3461

merged 2 commits into from Oct 14, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 13, 2022

closes #3460

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Oct 13, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2022
@caarlos0 caarlos0 added the enhancement New feature or request label Oct 13, 2022
@caarlos0 caarlos0 marked this pull request as ready for review Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #3461 (68cc224) into main (a15b7ec) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3461      +/-   ##
==========================================
+ Coverage   84.13%   84.15%   +0.02%     
==========================================
  Files         114      114              
  Lines        9226     9238      +12     
==========================================
+ Hits         7762     7774      +12     
  Misses       1188     1188              
  Partials      276      276              
Impacted Files Coverage Δ
internal/pipe/blob/upload.go 76.60% <100.00%> (+1.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 9e6fb4f into main Oct 14, 2022
12 of 13 checks passed
@caarlos0 caarlos0 deleted the blob-tmpl branch Oct 14, 2022
@github-actions github-actions bot added this to the v1.12.0 milestone Oct 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

region is not templated correctly in blobs: region:
1 participant