Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate ConventionalExtension from nfpm v2.20.0 #3468

Merged
merged 3 commits into from Oct 15, 2022

Conversation

Arsen6331
Copy link
Contributor

This PR upgrades nFPM to v0.20.0, and integrates the new ConventionalExtension method to use the correct extension for the packaging format that is being used.

Currently, goreleaser uses the name of the format to determine the extension. This has worked fine, but with the introduction of Archlinux packages, goreleaser has to handle packages with extensions that don't match the name of the format, since Archlinux uses .pkg.tar.zst as the extension.

goreleaser/nfpm#546
goreleaser/nfpm#543

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 15, 2022
@Arsen6331 Arsen6331 changed the title feat(deps): update nfpm to v2.20.0 feat: integrate ConventionalExtension from nfpm v2.20.0 Oct 15, 2022
@caarlos0
Copy link
Member

closes #3467

@caarlos0 caarlos0 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Oct 15, 2022
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #3468 (599bc8b) into main (9e6fb4f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3468   +/-   ##
=======================================
  Coverage   84.23%   84.24%           
=======================================
  Files         114      114           
  Lines        9292     9297    +5     
=======================================
+ Hits         7827     7832    +5     
  Misses       1189     1189           
  Partials      276      276           
Impacted Files Coverage Δ
internal/pipe/nfpm/nfpm.go 94.16% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit f6eb51c into goreleaser:main Oct 15, 2022
11 of 13 checks passed
@github-actions github-actions bot added this to the v1.12.0 milestone Oct 15, 2022
@Arsen6331 Arsen6331 deleted the nfpm-conventional-extension branch October 28, 2022 01:30
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants