Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement nfpm archlinux packages #3470

Merged
merged 5 commits into from Nov 2, 2022

Conversation

Arsen6331
Copy link
Contributor

@Arsen6331 Arsen6331 commented Oct 15, 2022

This PR implements the Archlinux packages that were added in nfpm v2.20.0, as well as tests and documentation for them.

goreleaser/nfpm#133
goreleaser/nfpm#543
Fixes #3469

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2022
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #3470 (8030f45) into main (0638b0a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Current head 8030f45 differs from pull request most recent head 6555592. Consider uploading reports for the commit 6555592 to get more accurate results

@@            Coverage Diff             @@
##             main    #3470      +/-   ##
==========================================
+ Coverage   84.25%   84.26%   +0.01%     
==========================================
  Files         114      114              
  Lines        9321     9329       +8     
==========================================
+ Hits         7853     7861       +8     
  Misses       1191     1191              
  Partials      277      277              
Impacted Files Coverage Δ
pkg/config/config.go 95.21% <ø> (ø)
internal/pipe/nfpm/nfpm.go 94.29% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Arsen6331
Copy link
Contributor Author

Arsen6331 commented Oct 28, 2022

The test is failing because nfpm v2.21.0 with the new code hasn't been released yet, so this will have to wait for that.

@caarlos0
Copy link
Member

@Arsen6331 I plan to release nfpm either tomorrow or early next week

@caarlos0
Copy link
Member

caarlos0 commented Nov 2, 2022

@Arsen6331 I plan to release nfpm either tomorrow or early next week

released, and updated on goreleaser main as well 0638b0a

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add archlinux to .goreleaser.yml?

@Arsen6331
Copy link
Contributor Author

Sure, one second

@caarlos0 caarlos0 added the enhancement New feature or request label Nov 2, 2022
@caarlos0 caarlos0 merged commit ad359a4 into goreleaser:main Nov 2, 2022
9 of 10 checks passed
@caarlos0
Copy link
Member

caarlos0 commented Nov 2, 2022

awesome, thank you @Arsen6331 ! <3

@github-actions github-actions bot added this to the v1.13.0 milestone Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create arch packages
2 participants