Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not run changelog on goreleaser build #3520

Merged
merged 1 commit into from Nov 2, 2022
Merged

fix: do not run changelog on goreleaser build #3520

merged 1 commit into from Nov 2, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 2, 2022

Its not really needed, nor used for anything, and can cause some issues.

fixes #3510

Its not really needed, nor used for anything, and can cause some issues.

Fixes #3510

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Nov 2, 2022
@caarlos0 caarlos0 self-assigned this Nov 2, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2022
@vercel vercel bot temporarily deployed to Preview November 2, 2022 00:28 Inactive
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #3520 (9f94acb) into main (de1e6bb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3520   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files         114      114           
  Lines        9297     9297           
=======================================
  Hits         7832     7832           
  Misses       1189     1189           
  Partials      276      276           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit 6fd8eec into main Nov 2, 2022
11 of 12 checks passed
@caarlos0 caarlos0 deleted the buldchglog branch November 2, 2022 16:08
@github-actions github-actions bot added this to the v1.13.0 milestone Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goreleaser build should skip changelog
2 participants