Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to template scoop/brew/krew repo ref #3521

Merged
merged 2 commits into from Nov 2, 2022
Merged

fix: allow to template scoop/brew/krew repo ref #3521

merged 2 commits into from Nov 2, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 2, 2022

closes #3508

  • adds template support for krew and scoop repo refs
  • template branch on reporef on brew as well

@caarlos0 caarlos0 self-assigned this Nov 2, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2022
@vercel vercel bot temporarily deployed to Preview November 2, 2022 01:19 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 2, 2022 01:22 Inactive
@caarlos0 caarlos0 added the bug Something isn't working label Nov 2, 2022
@caarlos0 caarlos0 marked this pull request as ready for review November 2, 2022 01:23
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #3521 (a8dc1ca) into main (de1e6bb) will increase coverage by 0.00%.
The diff coverage is 90.62%.

Current head a8dc1ca differs from pull request most recent head 11631fd. Consider uploading reports for the commit 11631fd to get more accurate results

@@           Coverage Diff           @@
##             main    #3521   +/-   ##
=======================================
  Coverage   84.24%   84.25%           
=======================================
  Files         114      114           
  Lines        9297     9321   +24     
=======================================
+ Hits         7832     7853   +21     
- Misses       1189     1191    +2     
- Partials      276      277    +1     
Impacted Files Coverage Δ
internal/pipe/krew/krew.go 82.64% <40.00%> (-0.90%) ⬇️
internal/client/config.go 100.00% <100.00%> (ø)
internal/pipe/brew/brew.go 83.16% <100.00%> (-0.33%) ⬇️
internal/pipe/scoop/scoop.go 71.85% <100.00%> (+0.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vercel vercel bot temporarily deployed to Preview November 2, 2022 17:50 Inactive
@caarlos0 caarlos0 merged commit 1a69d44 into main Nov 2, 2022
10 checks passed
@caarlos0 caarlos0 deleted the scoop-vars branch November 2, 2022 17:54
@github-actions github-actions bot added this to the v1.13.0 milestone Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoop pipeline doesn't substitute variables
1 participant