Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve artifactory error handling #3546

Merged
merged 1 commit into from Nov 12, 2022
Merged

fix: improve artifactory error handling #3546

merged 1 commit into from Nov 12, 2022

Conversation

caarlos0
Copy link
Member

closes #3543

closes #3543

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Nov 12, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Nov 12, 2022
@caarlos0 caarlos0 marked this pull request as ready for review November 12, 2022 03:38
@vercel vercel bot temporarily deployed to Preview November 12, 2022 03:38 Inactive
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #3546 (0a4297f) into main (c4fd0a0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3546   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files         116      116           
  Lines        9656     9656           
=======================================
  Hits         8076     8076           
  Misses       1280     1280           
  Partials      300      300           
Impacted Files Coverage Δ
internal/pipe/artifactory/artifactory.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 778f099 into main Nov 12, 2022
12 checks passed
@caarlos0 caarlos0 deleted the fix-artifactor branch November 12, 2022 03:49
@github-actions github-actions bot added this to the v1.13.0 milestone Nov 12, 2022
gal-legit pushed a commit to gal-legit/goreleaser that referenced this pull request Nov 13, 2022
closes goreleaser#3543

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper Handling of 413 Response
1 participant