Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show git error on debug #710

Merged
merged 4 commits into from Jul 4, 2018

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

caarlos0 commented Jul 4, 2018

Right now, if git fails, it doesn't matter if debug is enabled, because it won't print both stdout and stderr.

caarlos0 added some commits Jul 4, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 4, 2018

Codecov Report

Merging #710 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
- Coverage   89.13%   89.12%   -0.01%     
==========================================
  Files          45       45              
  Lines        2200     2198       -2     
==========================================
- Hits         1961     1959       -2     
  Misses        193      193              
  Partials       46       46
Impacted Files Coverage Δ
internal/git/git.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 874f53d...b898635. Read the comment docs.

@caarlos0 caarlos0 merged commit 47b6bd5 into master Jul 4, 2018

6 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 89.13%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +10.86% compared to 874f53d
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the debug branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.