Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve docker error handling #726

Merged
merged 1 commit into from Jul 17, 2018

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

caarlos0 commented Jul 17, 2018

improved the case in which a docker image may be declared but have no binaries matching it (which can really happen) and the case of a binary + goos + goarch + goarm combination matching more than one binary (can't happen right now).

Later it will just warn on the first case and do things wrong on the second, now it will error in both cases.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 17, 2018

Codecov Report

Merging #726 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   88.66%   88.67%   +<.01%     
==========================================
  Files          45       45              
  Lines        2074     2075       +1     
==========================================
+ Hits         1839     1840       +1     
  Misses        191      191              
  Partials       44       44
Impacted Files Coverage Δ
pipeline/docker/docker.go 97.1% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee706ae...0467645. Read the comment docs.

@caarlos0 caarlos0 merged commit ce83c85 into master Jul 17, 2018

6 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.66%)
Details
codecov/project 88.67% (+<.01%) compared to ee706ae
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the docker-err branch Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.