Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s3: credentials from env as well #733

Merged
merged 1 commit into from Jul 21, 2018

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

caarlos0 commented Jul 21, 2018

closes #731

uses the chained credential provider to get either from the config file or from env.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 21, 2018

Codecov Report

Merging #733 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #733      +/-   ##
=========================================
+ Coverage   88.69%   88.8%   +0.11%     
=========================================
  Files          45      45              
  Lines        2078    2082       +4     
=========================================
+ Hits         1843    1849       +6     
+ Misses        191     190       -1     
+ Partials       44      43       -1
Impacted Files Coverage Δ
pipeline/s3/s3.go 94.11% <100%> (+3.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5239f...52fb6b5. Read the comment docs.

@caarlos0 caarlos0 merged commit 170e6c6 into master Jul 21, 2018

6 checks passed

WIP ready for review
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the s3-cred branch Jul 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.