Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: s3: honor skip upload #738

merged 1 commit into from Jul 27, 2018


None yet
2 participants
Copy link

commented Jul 27, 2018

refs #737


This comment has been minimized.

Copy link

commented Jul 27, 2018

Codecov Report

Merging #738 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #738      +/-   ##
+ Coverage   88.88%   88.89%   +0.01%     
  Files          45       45              
  Lines        2088     2090       +2     
+ Hits         1856     1858       +2     
  Misses        189      189              
  Partials       43       43
Impacted Files Coverage Δ
pipeline/s3/s3.go 94.28% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba62d25...bc1b6ba. Read the comment docs.

@caarlos0 caarlos0 merged commit 82493e2 into master Jul 27, 2018

6 checks passed

WIP ready for review
codecov/patch 100% of diff hit (target 88.88%)
codecov/project 88.89% (+0.01%) compared to ba62d25
commit-message-check/gitcop All commit messages are valid
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@caarlos0 caarlos0 deleted the s3 branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.