Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip files were no longer being compressed #748

Merged
merged 1 commit into from Aug 6, 2018

Conversation

Projects
None yet
4 participants
@julienduchesne
Copy link
Contributor

julienduchesne commented Aug 6, 2018

Redo of goreleaser/archive#6

Hi, @caarlos0. We've had a regression here. This actually breaks zip files on macs here. When they are not compressed, it gives out a Bad ZIP file error when unzipping. That and they are 4 times as big :)

@GitCop

This comment has been minimized.

Copy link

GitCop commented Aug 6, 2018

There were the following issues with your Pull Request

  • Commit: c1d489c
  • Commits must be in the following format: %{type}: %{description}

Guidelines are available at https://github.com/goreleaser/goreleaser/blob/master/CONTRIBUTING.md#create-a-commit


This message was auto-generated by https://gitcop.com

GitHub
goreleaser - Deliver Go binaries as fast and easily as possible

@julienduchesne julienduchesne force-pushed the julienduchesne:zip-no-longer-compress branch from c1d489c to a8b7034 Aug 6, 2018

@GitCop

This comment has been minimized.

Copy link

GitCop commented Aug 6, 2018

There were the following issues with your Pull Request

  • Commit: a8b7034
  • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, add, remove, move, bump, update, release

Guidelines are available at https://github.com/goreleaser/goreleaser/blob/master/CONTRIBUTING.md#create-a-commit


This message was auto-generated by https://gitcop.com

GitHub
goreleaser - Deliver Go binaries as fast and easily as possible

@julienduchesne julienduchesne force-pushed the julienduchesne:zip-no-longer-compress branch from a8b7034 to 49dbf80 Aug 6, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 6, 2018

Codecov Report

Merging #748 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
+ Coverage   88.63%   88.63%   +<.01%     
==========================================
  Files          48       48              
  Lines        2146     2147       +1     
==========================================
+ Hits         1902     1903       +1     
  Misses        195      195              
  Partials       49       49
Impacted Files Coverage Δ
pkg/archive/zip/zip.go 76% <100%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fd1e1...49dbf80. Read the comment docs.

@caarlos0 caarlos0 merged commit f0413af into goreleaser:master Aug 6, 2018

5 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.63%)
Details
codecov/project 88.63% (+<.01%) compared to 32fd1e1
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caarlos0

This comment has been minimized.

Copy link
Member

caarlos0 commented Aug 6, 2018

thanks @julienduchesne 🚀

@julienduchesne julienduchesne deleted the julienduchesne:zip-no-longer-compress branch Aug 6, 2018

@julienduchesne

This comment has been minimized.

Copy link
Contributor Author

julienduchesne commented Aug 8, 2018

Hi, @caarlos0. Could you release this please? We'd like to release some stuff.
Thanks!

@caarlos0

This comment has been minimized.

Copy link
Member

caarlos0 commented Aug 8, 2018

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.