New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy all app metadata to default command #762

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
3 participants
@mgrachev
Contributor

mgrachev commented Aug 17, 2018

Hi there!

In my previous PR #749 I've added the default command for snapcraft pipeline. But I only copy the command without additional metadata. That solution doesn't work if we have additional metadata like plugs.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 17, 2018

Codecov Report

Merging #762 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
- Coverage   88.58%   88.57%   -0.01%     
==========================================
  Files          47       47              
  Lines        2137     2136       -1     
==========================================
- Hits         1893     1892       -1     
  Misses        195      195              
  Partials       49       49
Impacted Files Coverage Δ
internal/pipeline/snapcraft/snapcraft.go 89.58% <100%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838a265...303abfd. Read the comment docs.

@caarlos0

thanks

@caarlos0 caarlos0 merged commit e5c8000 into goreleaser:master Aug 20, 2018

5 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.58%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +11.41% compared to 838a265
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mgrachev mgrachev deleted the mgrachev:feature/update-snapcraft-pipeline branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment