New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add url template to scoop pipeline #768

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
2 participants
@mgrachev
Contributor

mgrachev commented Aug 20, 2018

Hi there!

I've added url_template to the scoop pipeline, as for homebrew.

@caarlos0

small issue, other than that seems fine!

Thanks!

@@ -11,6 +11,7 @@ import (
"github.com/goreleaser/goreleaser/internal/client"
"github.com/goreleaser/goreleaser/internal/pipeline"
"github.com/goreleaser/goreleaser/pkg/context"
"github.com/mgrachev/goreleaser/internal/tmpl"

This comment has been minimized.

@caarlos0

caarlos0 Aug 20, 2018

Member

wrong import path here, should be github.com/goreleaser :)

@mgrachev

This comment has been minimized.

Contributor

mgrachev commented Aug 20, 2018

@caarlos0 Fixed.

@caarlos0 caarlos0 merged commit 134e08c into goreleaser:master Aug 21, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
WIP ready for review
Details
commit-message-check/gitcop All commit messages are valid
Details
@caarlos0

This comment has been minimized.

Member

caarlos0 commented Aug 21, 2018

Thanks!

@mgrachev mgrachev deleted the mgrachev:feature/add-url-template-to-scoop branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment