Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry upload #900

Merged
merged 2 commits into from Dec 23, 2018

Conversation

Projects
None yet
3 participants
@caarlos0
Copy link
Member

caarlos0 commented Dec 22, 2018

closes #899

caarlos0 added some commits Dec 22, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 23, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@15d00f2). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #900   +/-   ##
=========================================
  Coverage          ?   87.83%           
=========================================
  Files             ?       48           
  Lines             ?     2375           
  Branches          ?        0           
=========================================
  Hits              ?     2086           
  Misses            ?      229           
  Partials          ?       60
Impacted Files Coverage Δ
internal/pipe/put/put.go 100% <ø> (ø)
internal/client/github.go 5.88% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d00f2...698c35c. Read the comment docs.

@caarlos0 caarlos0 merged commit 6e09a19 into master Dec 23, 2018

5 checks passed

WIP ready for review
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the retry-upload branch Dec 23, 2018

@caarlos0 caarlos0 restored the retry-upload branch Dec 23, 2018

@caarlos0 caarlos0 deleted the retry-upload branch Dec 23, 2018

@errordeveloper

This comment has been minimized.

Copy link

errordeveloper commented Dec 28, 2018

Strangely enough, I faced this error today:

+ goreleaser release --skip-validate '--config=./.goreleaser.brew.combined.yml'

   • releasing using goreleaser dev...
   • loading config file       file=./.goreleaser.brew.combined.yml
   • RUNNING BEFORE HOOKS     
   • GETTING AND VALIDATING GIT STATE
      • releasing 0.1.16, commit 907b8ea7028130837118eed2bf2b48a7fb0f438c
      • skipped                   reason=validation is disabled
   • SETTING DEFAULTS         
   • SNAPSHOTING              
      • skipped                   reason=not a snapshot
   • CHECKING ./DIST          
   • WRITING EFFECTIVE CONFIG FILE
      • writing                   config=dist/config.yaml
   • GENERATING CHANGELOG     
      • writing                   changelog=dist/CHANGELOG.md
   • LOADING ENVIRONMENT VARIABLES
   • BUILDING BINARIES        
      • building                  binary=dist/linux_amd64/eksctl
      • building                  binary=dist/windows_amd64/eksctl.exe
      • building                  binary=dist/darwin_amd64/eksctl
   • ARCHIVES                 
      • creating                  archive=dist/eksctl_Linux_amd64.tar.gz
      • creating                  archive=dist/eksctl_Darwin_amd64.tar.gz
      • creating                  archive=dist/eksctl_Windows_amd64.zip
   • LINUX PACKAGES WITH NFPM 
      • skipped                   reason=no output formats configured
   • SNAPCRAFT PACKAGES       
      • skipped                   reason=no summary nor description were provided
   • CALCULATING CHECKSUMS    
      • checksumming              file=eksctl_Darwin_amd64.tar.gz
      • checksumming              file=eksctl_Windows_amd64.zip
      • checksumming              file=eksctl_Linux_amd64.tar.gz
   • SIGNING ARTIFACTS        
      • skipped                   reason=artifact signing is disabled
   • DOCKER IMAGES            
      • skipped                   reason=docker section is not configured
   • PUBLISHING               
      • S3                       
      • skipped                   reason=s3 section is not configured
      • HTTP PUT                 
      • skipped                   reason=put section is not configured
      • Artifactory              
      • skipped                   reason=artifactory section is not configured
      • Docker images            
      • Snapcraft Packages       
      • GitHub Releases          
      • creating or updating release repo=weaveworks/eksctl tag=0.1.16
      • release updated           url=https://github.com/weaveworks/eksctl/releases/tag/0.1.16
      • uploading to release      file=dist/eksctl_checksums.txt name=eksctl_checksums.txt
      • uploading to release      file=dist/eksctl_Windows_amd64.zip name=eksctl_Windows_amd64.zip
      • uploading to release      file=dist/eksctl_Linux_amd64.tar.gz name=eksctl_Linux_amd64.tar.gz
      • uploading to release      file=dist/eksctl_Darwin_amd64.tar.gz name=eksctl_Darwin_amd64.tar.gz
   ⨯ release failed after 348.23s error=GitHub Releases: failed to publish artifacts: stat dist/eksctl_checksums.txt: use of closed file
make: *** [release] Error 1
Exited with code 2

It occurred two times in a row. More here: https://circleci.com/gh/weaveworks/eksctl/1672.

@errordeveloper

This comment has been minimized.

Copy link

errordeveloper commented Dec 28, 2018

Reverting to v0.77.2 solve the issue.

@caarlos0

This comment has been minimized.

Copy link
Member Author

caarlos0 commented Dec 28, 2018

this change wasn't released yet... will do it now =)

@errordeveloper

This comment has been minimized.

Copy link

errordeveloper commented Dec 28, 2018

caarlos0 added a commit that referenced this pull request Dec 28, 2018

Revert "fix: retry upload (#900)"
This reverts commit 6e09a19.

@caarlos0 caarlos0 referenced this pull request Dec 28, 2018

Merged

better retry upload #904

@caarlos0

This comment has been minimized.

Copy link
Member Author

caarlos0 commented Dec 28, 2018

I have tested this using the commit hash. Please look into what may have caused the error, if you can :) thanks!

dumb mistake from me... opened #904 to fix it.

caarlos0 added a commit that referenced this pull request Dec 28, 2018

fix: better retry upload (#904)
* Revert "fix: retry upload (#900)"

This reverts commit 6e09a19.

* fix: better upload retry

* fix: fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.