Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better retry upload #904

Merged
merged 3 commits into from Dec 28, 2018

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

caarlos0 commented Dec 28, 2018

current implementation on the client does not work well, as well its not the best place to do it, since we'll need to re-implement it on other clients when needed.

moved impl to the release pipe itself, also adding better tests for it.

refs #900

caarlos0 added some commits Dec 28, 2018

Revert "fix: retry upload (#900)"
This reverts commit 6e09a19.

@caarlos0 caarlos0 referenced this pull request Dec 28, 2018

Merged

fix: retry upload #900

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 28, 2018

Codecov Report

Merging #904 into master will increase coverage by 0.26%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   87.83%   88.09%   +0.26%     
==========================================
  Files          48       48              
  Lines        2375     2378       +3     
==========================================
+ Hits         2086     2095       +9     
+ Misses        229      223       -6     
  Partials       60       60
Impacted Files Coverage Δ
internal/client/github.go 6.25% <0%> (+0.36%) ⬆️
internal/pipe/release/release.go 88.57% <100%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e09a19...c29ea78. Read the comment docs.

@caarlos0 caarlos0 merged commit 8e42ab6 into master Dec 28, 2018

5 checks passed

WIP Legacy commit status override — see details
Details
codecov/patch 92.3% of diff hit (target 87.83%)
Details
codecov/project 88.09% (+0.26%) compared to 6e09a19
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the retry branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.