Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use retry package to repeat uploads #905

Merged
merged 1 commit into from Dec 29, 2018

Conversation

Projects
None yet
3 participants
@kamilsk
Copy link
Contributor

commented Dec 29, 2018

it's just a suggestion to simplify code, any feedback is welcome

kamilsk referenced this pull request Dec 29, 2018

fix: better retry upload (#904)
* Revert "fix: retry upload (#900)"

This reverts commit 6e09a19.

* fix: better upload retry

* fix: fmt
@caarlos0

This comment has been minimized.

Copy link
Member

commented Dec 29, 2018

There is a test failing, other that that looks good to me!

@codecov-io

This comment has been minimized.

Copy link

commented Dec 29, 2018

Codecov Report

Merging #905 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   88.09%   88.12%   +0.02%     
==========================================
  Files          48       48              
  Lines        2378     2383       +5     
==========================================
+ Hits         2095     2100       +5     
  Misses        223      223              
  Partials       60       60
Impacted Files Coverage Δ
internal/pipe/release/release.go 89.33% <100%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f1fd8...603cc7a. Read the comment docs.

@kamilsk kamilsk changed the title [WIP] use retry package to repeat uploads use retry package to repeat uploads Dec 29, 2018

@kamilsk

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2018

fixed

@caarlos0

This comment has been minimized.

Copy link
Member

commented Dec 29, 2018

thanks!

@caarlos0 caarlos0 merged commit 2cc4732 into goreleaser:master Dec 29, 2018

4 checks passed

WIP Legacy commit status override — see details
Details
codecov/patch 100% of diff hit (target 88.09%)
Details
codecov/project 88.12% (+0.02%) compared to 47f1fd8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kamilsk kamilsk deleted the kamilsk:retry-suggestion branch Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.