Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom_block to brew formula generation #906

Merged
merged 1 commit into from Dec 30, 2018

Conversation

Projects
None yet
3 participants
@fgsch
Copy link
Contributor

commented Dec 29, 2018

This allow authors to specify things such as devel, head and more.

I'm proposing this change so we can let users run projects from master.

See https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md#advanced-formula-tricks for details.

@codecov-io

This comment has been minimized.

Copy link

commented Dec 29, 2018

Codecov Report

Merging #906 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   88.12%   88.12%   +<.01%     
==========================================
  Files          48       48              
  Lines        2383     2384       +1     
==========================================
+ Hits         2100     2101       +1     
  Misses        223      223              
  Partials       60       60
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/brew/brew.go 89.14% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc4732...b804013. Read the comment docs.

@caarlos0

This comment has been minimized.

Copy link
Member

commented Dec 29, 2018

LGTM, can you also add it to brew.md?

@fgsch

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2018

Sure, I will add it and update this PR.

@fgsch

This comment has been minimized.

Copy link
Contributor Author

commented Dec 30, 2018

Doc added and rebased.

@caarlos0 caarlos0 merged commit d10c4f4 into goreleaser:master Dec 30, 2018

4 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.12%)
Details
codecov/project 88.12% (+<.01%) compared to 2cc4732
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caarlos0

This comment has been minimized.

Copy link
Member

commented Dec 30, 2018

awesome, thanks!

@fgsch fgsch deleted the fgsch:feat/custom-block branch Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.