Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support multiple binaries in scoop pipe #909

Merged
merged 2 commits into from Jan 5, 2019

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

caarlos0 commented Jan 1, 2019

now it should be able to support multiple builds and therefore multiple binaries.

refs #705

caarlos0 added some commits Jan 1, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 1, 2019

Codecov Report

Merging #909 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
+ Coverage    88.2%   88.22%   +0.02%     
==========================================
  Files          48       48              
  Lines        2399     2404       +5     
==========================================
+ Hits         2116     2121       +5     
  Misses        223      223              
  Partials       60       60
Impacted Files Coverage Δ
internal/pipe/scoop/scoop.go 88.37% <100%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850205a...cc4ad10. Read the comment docs.

@caarlos0 caarlos0 merged commit 23df4b5 into master Jan 5, 2019

5 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.2%)
Details
codecov/project 88.22% (+0.02%) compared to 850205a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the scoop-multiple branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.