Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple binaries on docker #919

Merged
merged 7 commits into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@caarlos0
Copy link
Member

commented Jan 11, 2019

closes #918

caarlos0 added some commits Jan 11, 2019

@jacobmarble

This comment has been minimized.

Copy link

commented Jan 11, 2019

#920 is apparently unrelated.

I tested this branch, works for me! Thanks tons @caarlos0 !

@codecov-io

This comment has been minimized.

Copy link

commented Jan 11, 2019

Codecov Report

Merging #919 into master will increase coverage by 0.07%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #919      +/-   ##
=========================================
+ Coverage   88.22%   88.3%   +0.07%     
=========================================
  Files          48      48              
  Lines        2404    2402       -2     
=========================================
  Hits         2121    2121              
+ Misses        223     222       -1     
+ Partials       60      59       -1
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/docker/docker.go 96.34% <93.75%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0255ab...9d66436. Read the comment docs.

@caarlos0

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

I tested this branch, works for me! Thanks tons @caarlos0 !

awesome! thanks for testing it out!

there are a couple more of test cases to add, will hopefully do it later today :D

thanks!

caarlos0 added some commits Jan 11, 2019

@caarlos0 caarlos0 merged commit cdfaae9 into master Jan 11, 2019

5 checks passed

WIP ready for review
Details
codecov/patch 93.75% of diff hit (target 88.22%)
Details
codecov/project 88.3% (+0.07%) compared to a0255ab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the docker-bins branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.