Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support skip tls on github cli #924

Merged
merged 11 commits into from Jan 19, 2019

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

caarlos0 commented Jan 17, 2019

quick hack to skip tls verify on github enteprise with self-signed certificates...

refs #916

caarlos0 added some commits Jan 17, 2019

@caarlos0 caarlos0 merged commit ae37eba into master Jan 19, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
WIP ready for review
Details

@caarlos0 caarlos0 deleted the https-github branch Jan 19, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #924 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
+ Coverage   88.62%   88.88%   +0.26%     
==========================================
  Files          49       49              
  Lines        2417     2457      +40     
==========================================
+ Hits         2142     2184      +42     
+ Misses        219      218       -1     
+ Partials       56       55       -1
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/client/github.go 12.62% <100%> (+6.37%) ⬆️
internal/pipe/git/git.go 100% <0%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742c8d0...0fcd7d1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.