Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support templates on docker.binaries #926

Merged
merged 2 commits into from Jan 18, 2019

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

caarlos0 commented Jan 17, 2019

closes #925

caarlos0 added some commits Jan 17, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #926 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   88.31%   88.34%   +0.02%     
==========================================
  Files          48       48              
  Lines        2405     2411       +6     
==========================================
+ Hits         2124     2130       +6     
  Misses        222      222              
  Partials       59       59
Impacted Files Coverage Δ
internal/pipe/docker/docker.go 96.47% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d7951a...0120e13. Read the comment docs.

@caarlos0 caarlos0 merged commit c22b367 into master Jan 18, 2019

5 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.31%)
Details
codecov/project 88.34% (+0.02%) compared to 7d7951a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the bins branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.