Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved semver parsing #930

Merged
merged 4 commits into from Jan 19, 2019

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

commented Jan 19, 2019

  • get and parse semver in a single place
  • semver now is available in the context
  • we may add prerelease to templates too
  • simplified some docker checks that happened to fail here for some reason now
  • removed extra semver checks
  • fixed issue with skip validate and semver ( closes #928 )

caarlos0 added some commits Jan 19, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 19, 2019

Codecov Report

Merging #930 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #930     +/-   ##
=========================================
+ Coverage   88.35%   88.66%   +0.3%     
=========================================
  Files          48       49      +1     
  Lines        2413     2452     +39     
=========================================
+ Hits         2132     2174     +42     
+ Misses        222      220      -2     
+ Partials       59       58      -1
Impacted Files Coverage Δ
internal/pipe/git/git.go 92.3% <ø> (-0.2%) ⬇️
internal/pipe/git/errors.go 100% <ø> (ø) ⬆️
pkg/context/context.go 100% <ø> (ø) ⬆️
internal/pipe/release/release.go 91.66% <100%> (+2.33%) ⬆️
internal/tmpl/tmpl.go 100% <100%> (ø) ⬆️
internal/pipe/semver/semver.go 100% <100%> (ø)
pkg/config/config.go 100% <0%> (ø) ⬆️
internal/pipe/changelog/changelog.go 99.09% <0%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f22d7...078f270. Read the comment docs.

@caarlos0 caarlos0 merged commit ed2ca57 into master Jan 19, 2019

5 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.35%)
Details
codecov/project 88.66% (+0.3%) compared to 98f22d7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the smever branch Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.