Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not override release notes #932

Merged
merged 1 commit into from Jan 19, 2019

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

caarlos0 commented Jan 19, 2019

this shall avoid overriding the release body if the release exists and the body is not empty...

refs #929
closes #856

@caarlos0 caarlos0 merged commit 4a8d526 into master Jan 19, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the do-not-override-release-notes branch Jan 19, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #932 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
- Coverage   88.65%   88.58%   -0.08%     
==========================================
  Files          49       49              
  Lines        2424     2426       +2     
==========================================
  Hits         2149     2149              
- Misses        219      221       +2     
  Partials       56       56
Impacted Files Coverage Δ
internal/client/github.go 12.38% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb33c5...a8b7d84. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.