Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/fix: improved CLI #937

Merged
merged 4 commits into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@caarlos0
Copy link
Member

commented Jan 22, 2019

  • moved changelog file load to the changelog pipe
  • created middlewares for common abstractions on Piper, Defaulter and Publisher actions
  • other smaller improvements

caarlos0 added some commits Jan 22, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 22, 2019

Codecov Report

Merging #937 into master will increase coverage by 0.13%.
The diff coverage is 90.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
+ Coverage   88.18%   88.31%   +0.13%     
==========================================
  Files          49       51       +2     
  Lines        2430     2440      +10     
==========================================
+ Hits         2143     2155      +12     
+ Misses        231      229       -2     
  Partials       56       56
Impacted Files Coverage Δ
pkg/context/context.go 100% <ø> (ø) ⬆️
internal/pipe/changelog/changelog.go 97.89% <100%> (+0.27%) ⬆️
internal/middleware/logging.go 100% <100%> (ø)
internal/middleware/error.go 100% <100%> (ø)
main.go 46.39% <72.72%> (-7.53%) ⬇️
internal/pipe/publish/publish.go 84.61% <80%> (+2.26%) ⬆️
internal/pipe/defaults/defaults.go 86.66% <80%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a8949...b9254fe. Read the comment docs.

@caarlos0 caarlos0 merged commit 60e54a1 into master Jan 22, 2019

5 checks passed

WIP ready for review
Details
codecov/patch 90.19% of diff hit (target 88.18%)
Details
codecov/project 88.31% (+0.13%) compared to 17a8949
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the cli branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.