Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to skip Homebrew Tap update for preleases #943

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@ahamilton55
Copy link
Contributor

ahamilton55 commented Jan 29, 2019

If applied, this commit will allow for pre-releases to not be pushed to a Homebrew tap.

Why is this change being made? When working on a tool that uses a Homebrew tap it would be helpful to be able to upload new releases to GitHub so that others can pull these down and test them manually but to help us prevent breaking the usage by other users that just want the current working version of the tool.

  • Updates Homebrew config to make "SkipUpload" a string so that it can
    contain more than true or false values. New available options are
    "true", "false" and "auto".
  • Adds a new check in Homebrew publish to see if it should skip due to a
    prerelease and "SkipUpload" set to auto.
  • Adds a new test to make sure that tap publishing is skipped when set
    to "auto" and a prerelease semver is provided.
  • Updates documents to add information about the new "auto" option for
    "SkipUpload".
feat: ability to skip Homebrew Tap update for preleases
- Updates Homebrew config to make "SkipUpload" a string so that it can
  contain more than true or false values. New available options are
  "true", "false" and "auto".
- Adds a new check in Homebrew publish to see if it should skip due to a
  prerelease and "SkipUpload" set to auto.
- Adds a new test to make sure that tap publishing is skipped when set
  to "auto" and a prerelease semver is provided.
- Updates documents to add information about the new "auto" option for
  "SkipUpload".
@bkeroackdsc

This comment has been minimized.

Copy link
Contributor

bkeroackdsc commented Jan 29, 2019

I was just affected by this issue where I inadvertently updated a stable homebrew formula with a prerelease, so it would be great if this can get merged.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #943 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #943      +/-   ##
==========================================
+ Coverage   88.31%   88.32%   +<.01%     
==========================================
  Files          51       51              
  Lines        2440     2442       +2     
==========================================
+ Hits         2155     2157       +2     
  Misses        229      229              
  Partials       56       56
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/brew/brew.go 89.31% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d183891...15f7f5c. Read the comment docs.

@caarlos0 caarlos0 merged commit f7bfac8 into goreleaser:master Jan 30, 2019

4 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.31%)
Details
codecov/project 88.32% (+<.01%) compared to d183891
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caarlos0

This comment has been minimized.

Copy link
Member

caarlos0 commented Jan 30, 2019

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.