Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support different checksum algorithms #951

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
None yet
4 participants
@caarlos0
Copy link
Member

commented Feb 4, 2019

closes #898

syntaqx and others added some commits Feb 4, 2019

feat: added more algorithms
Co-Authored-By: caarlos0 <caarlos0@users.noreply.github.com>
@codecov-io

This comment has been minimized.

Copy link

commented Feb 4, 2019

Codecov Report

Merging #951 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
+ Coverage   88.32%   88.41%   +0.09%     
==========================================
  Files          51       51              
  Lines        2442     2461      +19     
==========================================
+ Hits         2157     2176      +19     
  Misses        229      229              
  Partials       56       56
Impacted Files Coverage Δ
pkg/config/config.go 100% <ø> (ø) ⬆️
internal/pipe/checksums/checksums.go 100% <100%> (ø) ⬆️
internal/http/http.go 92.3% <100%> (ø) ⬆️
internal/pipe/scoop/scoop.go 88.37% <100%> (ø) ⬆️
internal/artifact/artifact.go 81% <100%> (+3.89%) ⬆️
internal/pipe/brew/brew.go 89.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457041f...63fb456. Read the comment docs.

@caarlos0 caarlos0 merged commit 7e79db1 into master Feb 4, 2019

5 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.32%)
Details
codecov/project 88.41% (+0.09%) compared to 457041f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@caarlos0 caarlos0 deleted the checksum branch Feb 4, 2019

@jspaleta

This comment has been minimized.

Copy link

commented Feb 4, 2019

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.