Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update retry package version #972

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
3 participants
@kamilsk
Copy link
Contributor

kamilsk commented Mar 2, 2019

I improved my package and updated its major version here.

@kamilsk

This comment has been minimized.

Copy link
Contributor Author

kamilsk commented Mar 2, 2019

Also, I suggest to wrap

defer file.Close() // nolint: errcheck
by safe.Close instead of use nolint: errcheck. It could be look like:

defer safe.Close(file)
// or
defer safe.Close(file, func (err error) { log.Println(err) }) // etc
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #972 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #972   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files          52       52           
  Lines        2491     2491           
=======================================
  Hits         2198     2198           
  Misses        233      233           
  Partials       60       60
Impacted Files Coverage Δ
internal/pipe/release/release.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8446761...d7cc1d7. Read the comment docs.

@caarlos0 caarlos0 merged commit b84f6cd into goreleaser:master Mar 3, 2019

4 checks passed

WIP Legacy commit status override — see details
Details
codecov/patch 100% of diff hit (target 88.23%)
Details
codecov/project 88.23% (+0%) compared to 8446761
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caarlos0

This comment has been minimized.

Copy link
Member

caarlos0 commented Mar 3, 2019

thanks!

@kamilsk

This comment has been minimized.

Copy link
Contributor Author

kamilsk commented Mar 3, 2019

@caarlos0, what do you about this #972 (comment) proposal? Can I add a dependency on my another package to use https://github.com/kamilsk/platform/blob/master/pkg/safe/close.go? Or it is not interesting to you. Or I can copy-paste it to your project.

GitHub
🧰 Platform is a toolkit for all my microservice family. - kamilsk/platform
@caarlos0

This comment has been minimized.

Copy link
Member

caarlos0 commented Mar 3, 2019

no need for now, thanks for the proposal though! :)

@kamilsk

This comment has been minimized.

Copy link
Contributor Author

kamilsk commented Mar 3, 2019

ok, thank you for your great project. goreleaser saved me a lot of time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.