Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants for http methods instead of strings #994

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
3 participants
@mgrachev
Copy link
Member

mgrachev commented Mar 31, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 31, 2019

Codecov Report

Merging #994 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #994   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files          52       52           
  Lines        2503     2503           
=======================================
  Hits         2204     2204           
  Misses        236      236           
  Partials       63       63
Impacted Files Coverage Δ
internal/http/http.go 92.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a0462...e735f2d. Read the comment docs.

@caarlos0 caarlos0 merged commit 7de2785 into goreleaser:master Mar 31, 2019

4 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 88.05%)
Details
codecov/project 88.05% (+0%) compared to 62a0462
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caarlos0

This comment has been minimized.

Copy link
Member

caarlos0 commented Mar 31, 2019

thanks!

@mgrachev mgrachev deleted the mgrachev:use-http-constant branch Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.