Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overhaul cmd and release process #325

Merged
merged 6 commits into from
Apr 23, 2021
Merged

feat: overhaul cmd and release process #325

merged 6 commits into from
Apr 23, 2021

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Apr 23, 2021

  • use cobra so its more like goreleaser
  • remove gocenter from goproxy
  • using "NFPM is a simple, 0-dependencies, deb, rpm and apk packager." as description in several places
  • completions for bash, fish and zsh (also in the brew tap and on the packages)
  • cmd docs on website
  • cmd code is pretty much ready to accept unit tests (although I haven't added any yet)
  • using commit timestamp et al on ldflags so the build is reproducible
  • using zip for windows archives
  • install the apk package inside the docker image, so we have completions et al there as well (although they wont work as we don't create completions for ash)
  • create a discussion for each release

overall, mimic a good deal of config/structure from goreleaser into nfpm.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Apr 23, 2021
@caarlos0 caarlos0 self-assigned this Apr 23, 2021
@vercel
Copy link

vercel bot commented Apr 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/9NocFS2XxrXEryNXH6KYxHQ8EB6k
✅ Preview: https://nfpm-git-cmd-overhaul-goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #325 (a356dfe) into master (1fb2691) will decrease coverage by 2.00%.
The diff coverage is 36.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   69.37%   67.36%   -2.01%     
==========================================
  Files           9       14       +5     
  Lines        1159     1284     +125     
==========================================
+ Hits          804      865      +61     
- Misses        223      285      +62     
- Partials      132      134       +2     
Impacted Files Coverage Δ
cmd/nfpm/main.go 0.00% <0.00%> (ø)
internal/cmd/docs.go 0.00% <0.00%> (ø)
internal/cmd/init.go 0.00% <0.00%> (ø)
internal/cmd/package.go 0.00% <0.00%> (ø)
internal/cmd/root.go 0.00% <0.00%> (ø)
rpm/rpm.go 73.20% <60.00%> (-0.67%) ⬇️
apk/apk.go 70.29% <100.00%> (+0.25%) ⬆️
internal/cmd/completion.go 100.00% <100.00%> (ø)
nfpm.go 86.88% <100.00%> (+1.56%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1413c...a356dfe. Read the comment docs.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 23, 2021
@vercel vercel bot temporarily deployed to Preview April 23, 2021 02:11 Inactive
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 23, 2021
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview April 23, 2021 02:14 Inactive
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview April 23, 2021 02:34 Inactive
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview April 23, 2021 02:58 Inactive
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview April 23, 2021 03:01 Inactive
@caarlos0 caarlos0 changed the title feat: overhaul cmd feat: overhaul cmd and release process Apr 23, 2021
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit c39b8ba into master Apr 23, 2021
@caarlos0 caarlos0 deleted the cmd-overhaul branch April 23, 2021 12:29
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge enhancement New feature or request size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants