Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apk version strings are incorrect #474

Closed
2 tasks done
kaniini opened this issue Mar 9, 2022 · 1 comment · Fixed by #514
Closed
2 tasks done

apk version strings are incorrect #474

kaniini opened this issue Mar 9, 2022 · 1 comment · Fixed by #514
Assignees
Labels
bug

Comments

@kaniini
Copy link

kaniini commented Mar 9, 2022

What happened?

In https://github.com/goreleaser/nfpm/blob/main/apk/apk.go#L562-L565, the version format is Debian-like. APK uses Gentoo-style versioning and will not understand these versions correctly.

How can we reproduce this?

Generate any APK with prerelease or epoch set. It will generate a bogus version string.

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

It would also be nice to refactor the apk writing part into its own module. At present, I cannot use nfpm's apk module for my own purposes :(

@kaniini kaniini added the bug label Mar 9, 2022
@caarlos0
Copy link
Member

caarlos0 commented Mar 9, 2022

hey @kaniini , thanks for bringing this up.

if you want to work on a PR for this it would be amazing... I can help through here/slack/discord if you need :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants