New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write proper tests for col2imOp #166

Open
chewxy opened this Issue Oct 2, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@chewxy
Member

chewxy commented Oct 2, 2017

Right now the tests are dummy tests and not real tests - it's essentially just a test that the operation doesn't fail.

The ideal test would test various edge cases:

  • Different padding
  • Negative padding
  • Different kernel widths
  • Negative kernel widths (failure condition)
  • Different strides
  • Negative strides (failure condition)
  • Different dilations
  • Negative dilations (failure condition)

@chewxy chewxy added the hacktoberfest label Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment