Op cleanup #65

chewxy · 2016-11-28T06:12:36Z

Fixes #3, #26 and #44


        inferShape -> InferShape (with gorename)


        returnsPtr -> ReturnsPtr (via gorename)


        callsExtern -> CallsExtern (via gorename)


        overwriteInput -> OverwritesInput (via gorename)


        Misc Op Interfaces changes


        Added Arity() method to Ops


        Starting work on fixing InferShape


        Starting work on fixing InferShape


        Start work on #44


        reworked most of the InferShape methods to use (...DimSizer). Now to …

…work on the method calls


        Quick one before I seleep


        InferShape() now uses ...DimSizer instead of ...*Node. Removed the ty…

…pe requirement too


        Renamed AdOp => ADOp

used checkArity() for more op methods preparing to create SDOp


        SDOp refactored out. need to handle errors for non-SDOps though


        Merge branch 'master' into OpCleanup


        Merge branch 'master' into ValueSimplification


        Merge branch 'master' into OpCleanup


        Merge branch 'OpCleanup' into ValueSimplification


        Moved out type system to use github.com/chewxy/hm


        Slowly fixing bugs


        Added tests for types in Gorgonia


        Added typeSystem_test.go


        Updated type systems. All tests passed... so far. Should fix #26


        Updated tests for type system. Type system for Gorgonia is now at 90+…

…% coverage


        Fixed small bugs in type checking


        Fixed type system to use the latest version of hm... it's twice as fa…

…st as previous but still 2/3rds the speed of the original


        Squashed commit of the following:

commit 9fb04b1580d74f644c7cc2e4de5258d6c2dbf7b1 Author: chewxy <chewxy@gmail.com> Date: Tue Nov 22 21:25:30 2016 +1100 Updated tests so that the type system is fully using v2 of HM commit 2db1eba9751e65b2bb5aef14d3727a462d0023a7 Author: chewxy <chewxy@gmail.com> Date: Tue Nov 22 01:13:53 2016 +1100 First pass at moving to the new v2 type system


        Added more test cases. The type system is properly tested as of now


        Added benchmarking for typesystem


        Fixed a bug in it that caused logisticregression example to panic due…

… to the change to use DimSizers


        updated tests to improve coverage


        Merge branch 'OpCleanup' into ValueSimplification


        Dual Values handled


        gorgonia.go done. Fixed up some ambiguity in Scalar


        op.go done


        op_math done


        done op_nn.go and op_reduction.go


        done op_tensor.go


        done with operatorPointwise_binary.go


        Done operatorPointwise_unary.go


        Added zero() and one() for basic functions. This leads to fewer types…

…witchin


        done solvers.go


        Done with various utilities


        updated vms...


        Cleanup. It works. Now to fix them tests


        Fixed up the tests to match the new Value types. Now the real testing…

… begins


        Ooh, lots of subtle bugs


        standardized definitions of dims for Tensors - vectors have len(shape…

…)==1.


        Updated examples and tensor packages


        Moved a portion of AnyTensor.Repeat() as a method of types.Shape. Thi…

…s is so that Gorgonia itself can also leverage that for shape inference purposes


        Updated Tensor Clone to facilitate better ops in Gorgonia


        Value Simplification done! Now to add more tests


        Updated tests for operatorPointwise_binary.go


        Updated solvers to test float32s as well

chewxy added 30 commits Nov 2, 2016

inferShape -> InferShape (with gorename)

000ffeb

returnsPtr -> ReturnsPtr (via gorename)

47b23be

callsExtern -> CallsExtern (via gorename)

4a441de

overwriteInput -> OverwritesInput (via gorename)

7983e57

Misc Op Interfaces changes

47a8079

Added Arity() method to Ops

5c82bb0

Starting work on fixing InferShape

e7ef075

Starting work on fixing InferShape

023d3c5

Start work on #44

94bf820

reworked most of the InferShape methods to use (...DimSizer). Now to …

3b7b07e

…work on the method calls

Quick one before I seleep

fdabc63

InferShape() now uses ...DimSizer instead of ...*Node. Removed the ty…

942f4b9

…pe requirement too

Renamed AdOp => ADOp

86c9932

used checkArity() for more op methods preparing to create SDOp

SDOp refactored out. need to handle errors for non-SDOps though

b9e3f31

Merge branch 'master' into OpCleanup

1ff2f32

Merge branch 'master' into ValueSimplification

f35e730

Merge branch 'master' into OpCleanup

0208227

Merge branch 'OpCleanup' into ValueSimplification

73b8f15

Moved out type system to use github.com/chewxy/hm

6139071

Slowly fixing bugs

c0475bb

Added tests for types in Gorgonia

3ce5a36

Added typeSystem_test.go

e2733f1

Updated type systems. All tests passed... so far. Should fix #26

8c7dbcc

Updated tests for type system. Type system for Gorgonia is now at 90+…

e9b364b

…% coverage

Fixed small bugs in type checking

d41db1a

Fixed type system to use the latest version of hm... it's twice as fa…

a462c6e

…st as previous but still 2/3rds the speed of the original

Added more test cases. The type system is properly tested as of now

9affff4

Added benchmarking for typesystem

6f7a2f5

Fixed a bug in it that caused logisticregression example to panic due…

ce2f576

… to the change to use DimSizers

chewxy added 24 commits Nov 22, 2016

updated tests to improve coverage

41dcb44

Merge branch 'OpCleanup' into ValueSimplification

6a54cdf

Dual Values handled

84df856

gorgonia.go done. Fixed up some ambiguity in Scalar

289fdcd

op.go done

fa84a7a

op_math done

5eaf344

done op_nn.go and op_reduction.go

7c3d387

done op_tensor.go

2d0cd9f

done with operatorPointwise_binary.go

cb6db61

Done operatorPointwise_unary.go

c1cc4cc

Added zero() and one() for basic functions. This leads to fewer types…

516d4fd

…witchin

done solvers.go

1c6a56d

Done with various utilities

ec23c97

updated vms...

541d731

Cleanup. It works. Now to fix them tests

3858aa8

Fixed up the tests to match the new Value types. Now the real testing…

2532263

… begins

Ooh, lots of subtle bugs

ac43e1c

standardized definitions of dims for Tensors - vectors have len(shape…

37ecf66

…)==1.

Updated examples and tensor packages

2fc94f7

Moved a portion of AnyTensor.Repeat() as a method of types.Shape. Thi…

fc75edd

…s is so that Gorgonia itself can also leverage that for shape inference purposes

Updated Tensor Clone to facilitate better ops in Gorgonia

ec1b176

Value Simplification done! Now to add more tests

d18cbe8

Updated tests for operatorPointwise_binary.go

cc35b6d

Updated solvers to test float32s as well

Loading status checks…

db86d5e

chewxy merged commit cf80bd6 into master Nov 28, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

chewxy deleted the OpCleanup branch Jan 6, 2017

chewxy mentioned this pull request Feb 22, 2017

Better Package Organization #91

Open

1 of 4 tasks complete

gorgonia/gorgonia

Op cleanup #65

Op cleanup #65

chewxy commented Nov 28, 2016

gorgonia/gorgonia

Join GitHub today

Op cleanup #65

Op cleanup #65

Conversation

chewxy commented Nov 28, 2016