Backport several improvements and fixes from the upstream #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related feedback: - gorhill/uBlock@7dd48a6#r41180568 Regression from: - gorhill/uBlock@7dd48a6
Related issue: - uBlockOrigin/uBlock-issues#877 Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Related issues: - uBlockOrigin/uBlock-issues#372 -gorhill/uBlock#93 A new advanced settings has been added: `autoCommentFilterTemplate`. Default value is `{{date}} {{origin}}`. Placeholders are identified by `{{...}}`. There are currently only three placeholders supported: - `{{date}}`: will be replaced with current date - `{{time}}`: will be replaced with current time - `{{origin}}`: will be replaced with site information on which the filter(s) was created If no placeholder is found in `autoCommentFilterTemplate`, this will disable auto-commenting. So one can use `-` to disable auto-commenting. Additionally, if auto-commenting is enabled, uBO will not emit a comment if an emitted comment would be a duplicate of the last one found in the user filter list. Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
Co-authored-by: gorhill <585534+gorhill@users.noreply.github.com>
hawkeye116477
changed the title
|
Thank you, here is the binary to test: uBlock0_1.16.4.25b2.firefox-legacy.xpi.zip (ping @THEtomaso). |
JustOff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Looks like that all should work fine, but maybe additional tests won't hurt, especially by @THEtomaso, who wanted one thing.