Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locales from upstream #273

Merged
merged 4 commits into from Oct 28, 2020
Merged

Update locales from upstream #273

merged 4 commits into from Oct 28, 2020

Conversation

hawkeye116477
Copy link
Contributor

@hawkeye116477 hawkeye116477 commented Oct 27, 2020

For the good start. Only 1 English string changed (whitelist export filename), rest strings are from other locales (mainly I updated strings which I noticed that got changed in my native language) and formatting, which is only cosmetic thing, nothing will change in output. For ease of use, I wrote on commit description which strings got updated and added script which I used to update strings (requires coreutils 8.15+).

* All related strings with whitelist/trusted sites (only one English string changed)
* dashboardUnsavedWarning for de
* Following strings got updated: settingsContextMenuPrompt, settingsHyperlinkAuditingDisabledPrompt, aboutRestoreDataButton, aboutPageName, aboutWiki, aboutSupport, popupTipLog (English strings not changed)
@JustOff
Copy link
Collaborator

@JustOff JustOff commented Oct 27, 2020

Thank you for making these changes step by step and for the detailed comments.

I made the translation import script work in the MozillaBuild environment, please check if it still works correctly on Linux.

@hawkeye116477
Copy link
Contributor Author

@hawkeye116477 hawkeye116477 commented Oct 28, 2020

It works correctly on Linux.

@JustOff JustOff merged commit 63aa999 into gorhill:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants