Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger #279

Merged
merged 2 commits into from Dec 1, 2020
Merged

Fix logger #279

merged 2 commits into from Dec 1, 2020

Conversation

hawkeye116477
Copy link
Contributor

@hawkeye116477 hawkeye116477 commented Nov 27, 2020 •
edited

hawkeye116477 and others added 2 commits Nov 27, 2020
@hawkeye116477 @gorhill
Improve compile-time error reporting in the logger.
4e91155 
This fixes gorhill#278.

Co-authored-by:  gorhill <585534+gorhill@users.noreply.github.com>
@gorhill @hawkeye116477
fix uBlockOrigin/uBlock-issues#149
6afc8d5
@hawkeye116477 hawkeye116477 changed the title Improve compile-time error reporting in the logger. Fix logger. Nov 28, 2020
@hawkeye116477 hawkeye116477 changed the title Fix logger. Fix logger Nov 28, 2020
@JustOff JustOff merged commit 52eb93b into gorhill:master Dec 1, 2020
@JustOff
Copy link
Collaborator

@JustOff JustOff commented Dec 1, 2020

Thank you.

@THEtomaso THEtomaso mentioned this pull request Jan 18, 2021
Closed
@THEtomaso
Copy link

@THEtomaso THEtomaso commented Jan 18, 2021

This has resulted in a regression:
#290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All has-text cosmetic filters logged as invalid in 1.16.4.24+
4 participants
@hawkeye116477 @JustOff @THEtomaso @gorhill