Skip to content
Permalink
Browse files

Finalize converting resources.txt into immutable resources

With hindsight, I revised decisions made earlier during
this development cycle:

Un-redirectable scriptlets have been removed from
/web_accessible_resources and instead put in the new
/assets/resources/scriptlets.js, which contains all
scriptlets used for web page injection purpose.

uBO will no longer fetch a remote version of built-in
resources.

Advanced setting `userResourcesLocation` will still be
honoured by uBO, and if set, will be fetched every
time at least one asset is updated.
  • Loading branch information
gorhill committed Jul 6, 2019
1 parent 813b390 commit 6f5aa947fb3b2abdd112411f34995233b28f7bf9
@@ -19,10 +19,7 @@
"ublock-resources": {
"content": "internal",
"updateAfter": 7,
"contentURL": [
"https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/resources.txt",
"assets/ublock/resources.txt"
]
"contentURL": "assets/ublock/resources.txt"
},
"ublock-filters": {
"content": "filters",

4 comments on commit 6f5aa94

@jspenguin2017

This comment has been minimized.

Copy link
Contributor

jspenguin2017 replied Jul 6, 2019

@gorhill Did you forget to remove application/javascript here? 6f5aa94#diff-d7616deaf3a39e3f19f8d70d098bfe7aR687

@gorhill

This comment has been minimized.

Copy link
Owner Author

gorhill replied Jul 6, 2019

Yes I did, thanks.

@uBlock-user

This comment has been minimized.

Copy link
Contributor

uBlock-user replied Jul 6, 2019

Would you still be adding new scriptlets to resources.txt or will go straight to scriptlets.js from now on ?

@gorhill

This comment has been minimized.

Copy link
Owner Author

gorhill replied Jul 6, 2019

resources.txt is dead, I won't add stuff to it anymore. It was useful when I started to use scriptlets to quickly deal with all the stuff the web threw at users, but eventually it has stabilized enough now that it had become tedious to deal with it. All built-in scriptlets will go into /assets/resources/scriptlets.js (or /web_accessible_resources/ if redirection is needed), this allows to jshint, syntax coloring, test scriptlets with dev build before releasing the the wider public, etc.

Please sign in to comment.
You can’t perform that action at this time.