New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add private mode filters to make uBO part of GNU IceCat #1576
Comments
Wouldn't that require platform specific changes? |
This would be a good time for someone to make a "SpyBlock Origin" fork or something like that, with the desired platform-specific functionality; I'm thinking that whatever was done to allow an Adblock Plus fork to activate a certain filter-list in private mode would be portable across Firefox extensions. |
I do not intend to create/maintain yet another extension. |
@gorhill This is not about create/maintain another extension but to add a private mode detection to uBO. If the author or IceCat would do that, would you adopt it then? |
Most likely not, because I can't make sense of such feature. I fail to see the point of a "non private mode" for uBO, which is what supporting a special "private mode" implies. |
@gorhill Thank you. I told the icecat bugzilla mailing list about this so the IceCat maintainer can decide if he think its worth to do it himself. |
I suggest that SpyBlock (part of GNU IceCat) fork its code from uBlock [Origin] rather than Adblock Plus.
IceCat author (Rubén Rodríguez) responded: "I made the Spyblock hack before uBlock was available (or well known
anyway). It could be replaced, provided that we can implement with
uBlock the same features SpyBlock provides over Adblock: extra lists
that get enabled when entering private mode.
Since Spyblock is providing the desired functionality right now,
replacing it for the sake of performance is not a priority compared with
improving LibreJS, which is what I'll be working on next. But if
somebody wants to contribute that code I'll be happy to add it."
The text was updated successfully, but these errors were encountered: