Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty whitelist applies default whitelist #171

Closed
seanrand opened this issue May 4, 2015 · 1 comment

Comments

@seanrand
Copy link
Contributor

commented May 4, 2015

Affects both latest master of uBlock Origin and uBlock.
To reproduce:

  1. Apply behind-the-scene * * noop rule
  2. Delete everything from the whitelist and apply changes
  3. Open Behind the scene in request log
  4. Open a GitHub tab (or any other page that uses navigator beacons)
  5. Observe https://www.google-analytics.com/collect not being blocked in the request log
  6. Add # to the whitelist and apply changes
  7. Refresh GitHub tab
  8. Observe https://www.google-analytics.com/collect being blocked in the request log

Without looking into it, my guess is that when the whitelist is completely empty, uBlock uses the default whitelist (with behind-the-scene whitelisted) instead.

@gorhill

This comment has been minimized.

Copy link
Owner

commented May 4, 2015

Never mind, I read more carefully.

@gorhill gorhill closed this in 65183f7 May 4, 2015

gorhill added a commit that referenced this issue May 4, 2015
chrisaljoudi added a commit to uBlock-LLC/uBlock that referenced this issue May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.