uBO 1.7.7beta -- Cosmetic filters using [style="..."] not working

[onestepbeyond]

Describing the issue

Since uBO 1.7.7_beta_, following sort of filter no longer works: forum.pcastuces.com##DIV[style="background-color:#eff4fc;margin:auto;font-size:1.2em;text-align:center;width:80%;border:1px solid #c9c9c9;padding:5px;"]

One or more specific URLs where the issue occurs

• https://forum.pcastuces.com/recuperer_fenetre_automatique_pour_telecharger_photos_iphone_5-f21s7118.htm?page=1&#5514204
• https://forum.pcastuces.com/est_ce_normal-f13s5020.htm?page=1&#5514250
• https://forum.pcastuces.com/zimbra-f6s69637.htm?page=1&#5514270

Screenshot in which the issue can be seen

Steps for anyone to reproduce the issue

• With uBO 1.7.7_beta_, click any link above and notice that the table near the footer is displayed.
• Reproduce with uBO 1.7.6 or prior and notice that this table is correctly hidden.

My settings

• OS: Win XP SP3
• Browser/version: Firefox ESR 38.8.0
• uBlock Origin version: 1.7.7b8

My filter lists

Your custom filters (if any): none

[gorhill]

Can you confirm this was with 1.7.7b8?

[onestepbeyond]

Yes, I do confirm. I think I noticed this since 1.7.7b7. (b9 impacted as well).
-- sorry, I had opened a duplicate topic in uAssets. I do not know which to close and which to leave open.

[gorhill]

Ok I see the issue, it's a code issue. The new code fixes cases like #963, but breaks cosmetic filters which use [style="..."]. This means cosmetic filters with such part will have to be apply in a declarative way only.

[onestepbeyond]

OK. What means exactly "declarative way" ? Should I manually change something in such filters ?
or this question makes no sense... ? I feel so stupid with uBO, how frustrating...

[gorhill]

Meanwhile, since you are using the beta version, use: forum.pcastuces.com##body > div:has(a[href="enregistrement.asp"])

[gorhill]

When I use "declarative" I mean the CSS rule will be injected in a style tag, and no further action will be taken. "Further action" means that uBO, on top of injecting style tags, will also visit all affected DOM elements to force display: none !important on them, to be sure sites do not try to override uBO's cosmetic filtering. But changing the style of an element to force-hide it has the side effect of modifiying its style attribute, which causes the DOM element to no longer match the cosmetic filter which is based on the style attribute. This is also what causes #435. The code refactoring in 1.7.7 made the issue more prominent (but resolved other cases) -- but it was already in there for FF at least since shadow DOM is not supported by default.

[onestepbeyond]

Meanwhile, since you are using the beta version, use: forum.pcastuces.com##body > div:has(a[href="enregistrement.asp"])

Wow! works and :has seems fantastic! 👍

Thanks for the additional explanations.

[onestepbeyond]

I just noticed that infortunately, the header goes away (same target).
Does not matter at this stage, I will wait for the release.

[gorhill]

Try forum.pcastuces.com##body > div[style]:has(:scope > a[href="enregistrement.asp"]).

[onestepbeyond]

As far as I can see after testing several scenarios, that filter seems working without side-effect.:ok_hand: