Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetically filtered DOM elements in embedded frames are not counted #1856

Closed
gorhill opened this Issue Aug 4, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@gorhill
Copy link
Owner

commented Aug 4, 2016

Describe the issue

I became aware of this bug when I investigate the issue reported in uBlockOrigin/uAssets#91.

Toggling the cosmetic filtering switch showed that there were many DOM elements hidden on the page as a result of cosmetic filtering (also as evidenced by the logger output), and yet the cosmetic filtering switch in uBO's popup panel was showing no DOM element being filtered.

The cause is that uBO does not count filtered DOM elements in embedded frames, only those in the top document.

Steps for anyone to reproduce the issue

Follow steps in uBlockOrigin/uAssets#91.

Your settings

This occurs on any browser, any version of uBO (1.8.0 and less).

Your filter lists

EasyList must be selected for the repro case.

@gorhill gorhill closed this in 6bd356d Aug 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.