Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Describe the issue
Generic cosmetic filters are not applied to topics on phpBB forums after visiting more than 15 topics on which said generic cosmetic filters would have no effect.
One or more specific URLs where the issue occurs
Steps for anyone to reproduce the issue
Expected results: github link is hidden
Actual results: github link is visible, and the cosmetic filter is not reported in the logger.
(Related discussion on informaction: https://forums.informaction.com/viewtopic.php?f=18&t=21619&start=30#p84250 )
Your filter lists
Your custom filters (if any)
Generic Filters are not being applied.
Right click on "Latest Popular Episodes" block and click Block Element
Select and apply Cosmetic Filter "##.block-left-home-title"
Now browse to "chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/dashboard.html#1p-filters.html"
Remove the website name from the cosmetic filter which will turn it into a generic filter and click Apply Changes.
Refresh the web page, and the "Latest Popular Episodes" block will be back.
Add the website name back as and the cosmetic filter will be applied successfully again.
PS - Ignore generic cosmetic filters is NOT activated and this still happens, so I guess the bug lies somewhere there. This is happening still with version 1.9.16
because the filter applied is really
Currently you can't override a filter such as
However, since uBO supports the
Hi @gorhill I run a ' Web Annoyances' filter list and have a similar experience with generic filters on all websites that use the 'medium.com' blog platform as well as other sites that use their platform.
Use case can be tested on the link below: https://medium.com/buzzfeed-collections/internets-favorite-congressman-b7002ad4f3fa#.f3upjdryx
When I add the following generic filter with no domain name in front of the ## to 'My Filters'
However, if I use the same cosmetic filter, but include the domain, uBO seems to work as intended (i.e.
You can test the impact of what this filter is attempting to block by scrolling down a little bit on the page and then scrolling up, with no filter set, or the generic filter without a domain. You should see a navbar overlay descend from the top of the page. However, when you use a domain in front of the generic filter, the filter applies and the navbar is no longer visible.
The only sites I have seen uBO work this way are on the medium blog platform, so impacted sites for example would be medium.com, backchannel.com, theringer.com, timeline.com, wearemel.com, howwegettonext.com, etc.
The other curious thing, is that it ONLY seems to impact the top navbar, other generic elements that are shared between medium blog platform sites can be blocked without a domain in front of the cosmetic filter so I'm not sure why the navbar cosmetic filter doesn't apply when there is no domain prefix. You can test that other generic elements are being blocked without the domain name by setting the following filter that gets used by all of the domains listed above.
Test articles to show the 3 generic filters above are being applied across multiple domains that use the medium platform could be the following links:
The preceding generic filters will block a couple different 'fly-in' boxes at the end of an article and WORK without a domain name prefix for articles on any of the previously listed domains (medium.com, backchannel.com, theringer.com, timeline.com, wearemel.com, howwegettonext.com, etc.) that use the medium blog platform.
Please note, from what I have found, the medium sites use different navbar or what medium seems to call 'metabar' element names such as the following (there are more, but don't need to post them all probably):
but none of the navbar filters will work without a domain in front of the cosmetic filter.
Sorry if this is a long post, and I hope I clearly explain what the issue is and how to replicate the generic filters not being applied in certain situations. Please let me know if I can provide further information.