Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABP Subscription Links Not Understood #2622

Closed
pjpreilly opened this issue May 17, 2017 · 3 comments

Comments

@pjpreilly
Copy link

commented May 17, 2017

Filter issues MUST NOT be reported here. Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

Describe the issue

Trying to add filter subscriptions from filterlists.com. Clicking add returns an error for ABP protocol. This is the only OS I have the problem on. Works fine on Windows 10 as well as any OS x I've tried. Also Adblock plus works fine on this OS on both browsers. This problem occurs without Adblock Plus enabled/Installed.

One or more specific URLs where the issue occurs

abp:subscribe?location=https%3A%2F%2Feasylist-downloads.adblockplus.org%2Fadwarefilters.txt&title=Adware%20Filters (This is the exact URL)
[URL(s) for issue on a specific site are mandatory]

Screenshot in which the issue can be seen

[Screenshot(s) for visual issues are mandatory]
screenshot_2017-05-14_20-51-56

Steps for anyone to reproduce the issue

Go to the filterlists.com website
Click ADD to any filter subscription
observe error (Picture)

Your settings

[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]

  • OS/version: Manjaro (32 bit) latest stable (rolling release Xfce desktop)
  • Browser/version: Firefox 52.1.0 esr (as well as Chromium 58.0.3029.110-1)
  • uBlock Origin version: 1.12.4
Your filter lists

NA
[Example: "Default filter lists + FRA", or "Default filter lists minus uBlock -- Badware risks"]

Your custom filters (if any)

NA

@gwarser

This comment has been minimized.

Copy link
Contributor

commented May 17, 2017

Using left mouse button? This happens when opening in new tab, because is handled by content script.

@gorhill

This comment has been minimized.

Copy link
Owner

commented May 17, 2017

Timing issue, already reported at: collinbarrett/FilterLists#79 (comment).

Potential solution: adding a (1 second?) delay before checking for abp: links on the page.

@pjpreilly

This comment has been minimized.

Copy link
Author

commented May 17, 2017

@gorhill Would/should pre-loading filterlists.com first with Ublock disabled & the enabling Ublock have any affect on the timing? Would you expect this to be a work around?

UPDATE: It is a work around & does confirm the timing issue.

@gorhill gorhill closed this in fd776bb May 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.