Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu has too much space on the top and bottom #2696

Closed
streetwolf opened this issue Jun 10, 2017 · 6 comments

Comments

@streetwolf
Copy link

commented Jun 10, 2017

Icon menu has extra space on the top and bottom as seen where I place arrows on the screenshot. Mozilla fixed the menu being too wide but evidently didn't fix this problem. I thought I saw a patch that addressed this on Bugzilla but I could be wrong or it didn't work.

Running latest Fx55 Nightly. Running uBlock Origin v1.12.5rc2. Windows 10 64 bit CU with all cumulative updates.

Filter lists not applicable in this case.

untitled

@streetwolf

This comment has been minimized.

Copy link
Author

commented Jun 10, 2017

The extra space is produced when you turn on Photon mode via 'browser.photon.structure.enabled = true' in prefs.js. Normal mode it looks OK. Photon will be upon us soon so it might be proactive to get this fixed soon.

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 10, 2017

Shouldn't this be filed in Firefox issue tracker?

uBO embed its frame into the Firefox's-provided panel, and that panel has a padding style causing the issue (line 339 in panelUI.css):

/* START photonpanelview adjustments */

#appMenu-popup > .panel-arrowcontainer > .panel-arrowcontent {
  padding: 0;
  border-radius: 0;
}

photonpanelmultiview panelview {
  background: var(--arrowpanel-background);
  padding: 6px 0;
}

When commenting out the padding style above (the 6px one), it renders fine. The padding style above is in addition to the padding style seen in one of the ancestor element (line 328 in panelUI.css):

.cui-widget-panel > .panel-arrowcontainer > .panel-arrowcontent {
  padding: 4px 0;
}

Meaning the resulting padding is 10 pixels with Photon. I doubt this was meant to be this much. One of the two styles probably needs to be revised.

@streetwolf

This comment has been minimized.

Copy link
Author

commented Jun 10, 2017

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 10, 2017

Are you re-writing uBO for WE or waiting until WE becomes more stable?

See #2684 (comment). uBO does not need to be re-written, the Chromium version is the webext version, with very minor changes.

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 10, 2017

Looking a bit more into this, I could set the padding myself, but that seems a odd thing to do for uBO, as it would force uBO to make assumption about and deal with stuff which are not its responsibility. It's unclear to me what was the intended behavior here by whoever is working on Photon.

@gorhill gorhill closed this in e611879 Jun 10, 2017

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 10, 2017

I just forced the style in uBO, faster for me to change the chrome style than to report an issue on bugzilla. Tested with Pale Moon, Sea Monkey, Firefox 53, Nightly with and without Photon, with legacy and webext.

This means that legacy without Photon won't have padding anymore at the top and bottom like it used to be. Never mind, not true, it's the webext version of uBO on non-Photon Firefox which has no padding.

gorhill added a commit to gorhill/uMatrix that referenced this issue Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.